This repository has been archived by the owner on Jul 15, 2019. It is now read-only.
improved benchmark suite #25
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@maditya , please review. thanks. |
|
CLA is valid! |
|
👍 |
|
The usage would need an update. Everything else is good. |
adon-at-work
force-pushed
the
improved-benchmark-suite
branch
from
39e1b5b to
372dac9
Compare
|
this is ready for another round of review. @maditya / @yukinying , thanks. |
| // }) | ||
| .on('cycle', function(event) { | ||
| console.log(String(event.target)); | ||
| }) |
There was a problem hiding this comment.
Why do you need to dump event.target to console log?
There was a problem hiding this comment.
this shows the intermediate results of every test. now we have only one test, but we'll have more...
if that onCycle dump is commented. nothing will show up until everything is completed. that'd look like hanged...
There was a problem hiding this comment.
in other words, if that is omitted, we will miss something like below
default x 0.64 ops/sec ±5.90% (6 runs sampled)
but will only see:
Fastest is [ 'default' ]
Speed/Time is 0.6423016849725829MB/s 1.5567777936666667s
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use
benchmarkfor benchmarking